Add expiration check into dart.js script.

Add expiration check into dart.js script.

R=podivilov@chromium.org,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=7713

[vsm, 2012-05-16 19:14:01]

lgtm

https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js#newcode7
client/dart.js:7: if (navigator.webkitStartDart()) {
Minor nit: I'd suggest changing failure from true to false.  I.e., it'd be more
intuitive to have webkitStartDart return false if it fails.

[Anton Muhin, 2012-05-17 14:20:28]

https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js#newcode7
client/dart.js:7: if (navigator.webkitStartDart()) {
We need to think out landing process as if I change C++ implementation, people
we fresh builds will be told to upgrade, but there will be no warning to people
with outdated builds.

wdyt, should we change it or maybe leave it as is now?

On 2012/05/16 19:14:01, vsm wrote:
> Minor nit: I'd suggest changing failure from true to false.  I.e., it'd be
more
> intuitive to have webkitStartDart return false if it fails.

[vsm, 2012-05-17 15:30:56]

On 2012/05/17 14:20:28, antonmuhin wrote:
> https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js
> File client/dart.js (right):
> 
> https://chromiumcodereview.appspot.com/10383215/diff/1/client/dart.js#newcode7
> client/dart.js:7: if (navigator.webkitStartDart()) {
> We need to think out landing process as if I change C++ implementation, people
> we fresh builds will be told to upgrade, but there will be no warning to
people
> with outdated builds.
> 
> wdyt, should we change it or maybe leave it as is now?
> 

Your call.  Hopefully, we'll figure a way around it in the long term anyway.

> On 2012/05/16 19:14:01, vsm wrote:
> > Minor nit: I'd suggest changing failure from true to false.  I.e., it'd be
> more
> > intuitive to have webkitStartDart return false if it fails.