Issue 10383213: Attempt at fixing crash in constrained window used by printing. I

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383213: Attempt at fixing crash in constrained window used by printing. I (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Attempt at fixing crash in constrained window used by printing. I suspect the page is closing the constrained dialog, which deletes the delegate so that if the dialog attempts to use the delegate we crash. BUG=127370 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137463

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10383213/1

8 years, 7 months ago (2012-05-16 16:48:00 UTC) #3

Change committed as 137463

Expand Messages | Collapse Messages