Issue 10383208: Tweak Memcheck sanity tests to avoid duplicate reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383208: Tweak Memcheck sanity tests to avoid duplicate reports. (Closed)

Created:
8 years, 7 months ago by eugenis

Modified:
8 years, 7 months ago

Reviewers:
Lei Zhang, Alexander Potapenko, Timur Iskhodzhanov, jar (doing other things)

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Tweak Memcheck sanity tests to avoid duplicate reports. BUG=128264 TEST=ToolsSanityTest under valgrind TBR=jar Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137383

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/tools_sanity_unittest.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

8 years, 7 months ago (2012-05-16 08:34:12 UTC) #3

LGTM if this works
I think you can feel free to commit with TBR (i.e. without waiting for
a base/ approval)

On Wed, May 16, 2012 at 10:50 AM,  <eugenis@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov, Lei Zhang, Alexander Potapenko,
>
> Description:
> Tweak Memcheck sanity tests to avoid duplicate reports.
>
> BUG=128264
> TEST=ToolsSanityTest under valgrind
>
> Please review this at https://chromiumcodereview.appspot.com/10383208/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/tools_sanity_unittest.cc
>
>
> Index: base/tools_sanity_unittest.cc
> ===================================================================
> --- base/tools_sanity_unittest.cc       (revision 137086)
> +++ base/tools_sanity_unittest.cc       (working copy)
> @@ -28,10 +28,10 @@
>  #endif
>
>  void ReadUninitializedValue(char *ptr) {
> -  // The || in the conditional is to prevent clang from optimizing away the
> +  // Comparison with 64 is to prevent clang from optimizing away the
>   // jump -- valgrind only catches jumps and conditional moves, but clang
> uses
>   // the borrow flag if the condition is just `*ptr == '\0'`.
> -  if (*ptr == '\0' || *ptr == 64) {
> +  if (*ptr == 64) {
>     (*ptr)++;
>   } else {
>     (*ptr)--;
>
>

Expand Messages | Collapse Messages