Expose HTTP version number in responses.

webkit/glue/weburlloader_impl.cc

Index: webkit/glue/weburlloader_impl.cc
diff --git a/webkit/glue/weburlloader_impl.cc b/webkit/glue/weburlloader_impl.cc
index dda17df64518b212fe297696636c9aea4870524f..c6bcab8732da198796f6acf6f7de4c9bee2e20aa 100644
--- a/webkit/glue/weburlloader_impl.cc
+++ b/webkit/glue/weburlloader_impl.cc
@@ -229,6 +229,14 @@ void PopulateURLResponse(
   if (!headers)
     return;
 
+  WebURLResponse::HTTPVersion version = WebURLResponse::Unknown;
+  if (headers->GetHttpVersion() == net::HttpVersion(0, 9))
+    version = WebURLResponse::HTTP_0_9;
+  else if (headers->GetHttpVersion() == net::HttpVersion(1, 0))
+    version = WebURLResponse::HTTP_1_0;
+  else if (headers->GetHttpVersion() == net::HttpVersion(1, 1))

[darin (slow to review), 2012/05/21 23:39:07]

you should probably complain if GetHttpVersion() returns some other value, like
2.0 :-)

too bad net::HttpVersion isn't just an int so you could case/switch!

[Ami GONE FROM CHROMIUM, 2012/05/21 23:49:23]

What kind of complaint did you have in mind?  
(none of LOG/DCHECK/CHECK seem appropriate to me)
Note that the code already sets Unknown in the unexpected case.

+    version = WebURLResponse::HTTP_1_1;
+  response->setHTTPVersion(version);
   response->setHTTPStatusCode(headers->response_code());
   response->setHTTPStatusText(WebString::fromUTF8(headers->GetStatusText()));