Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 10383201: Expose HTTP version number in responses. (Closed)

Created:
8 years, 7 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Expose HTTP version number in responses. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138332

Patch Set 1 #

Patch Set 2 : Updated to newer version of webkit patch. #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M webkit/glue/weburlloader_impl.cc View 1 2 3 1 chunk +8 lines, -0 lines 2 comments Download
M webkit/media/buffered_resource_loader.cc View 1 2 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
Ami GONE FROM CHROMIUM
This depends on the not-yet-landed http://webk.it/86522
8 years, 7 months ago (2012-05-15 21:27:22 UTC) #1
Ami GONE FROM CHROMIUM
Darin: can you take a look at this? (jamesr declined networky review)
8 years, 7 months ago (2012-05-18 14:12:50 UTC) #2
darin (slow to review)
https://chromiumcodereview.appspot.com/10383201/diff/2004/webkit/glue/weburlloader_impl.cc File webkit/glue/weburlloader_impl.cc (right): https://chromiumcodereview.appspot.com/10383201/diff/2004/webkit/glue/weburlloader_impl.cc#newcode237 webkit/glue/weburlloader_impl.cc:237: else if (headers->GetHttpVersion() == net::HttpVersion(1, 1)) you should probably ...
8 years, 7 months ago (2012-05-21 23:39:07 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10383201/diff/2004/webkit/glue/weburlloader_impl.cc File webkit/glue/weburlloader_impl.cc (right): https://chromiumcodereview.appspot.com/10383201/diff/2004/webkit/glue/weburlloader_impl.cc#newcode237 webkit/glue/weburlloader_impl.cc:237: else if (headers->GetHttpVersion() == net::HttpVersion(1, 1)) On 2012/05/21 23:39:07, ...
8 years, 7 months ago (2012-05-21 23:49:22 UTC) #4
darin (slow to review)
On Mon, May 21, 2012 at 4:49 PM, <fischman@chromium.org> wrote: > > https://chromiumcodereview.**appspot.com/10383201/diff/** > 2004/webkit/glue/weburlloader_**impl.cc<https://chromiumcodereview.appspot.com/10383201/diff/2004/webkit/glue/weburlloader_impl.cc> ...
8 years, 7 months ago (2012-05-22 05:24:04 UTC) #5
Ami GONE FROM CHROMIUM
Couldn't a web server claim anything it wanted?
8 years, 7 months ago (2012-05-22 05:25:12 UTC) #6
darin (slow to review)
That's a good point! OK On Mon, May 21, 2012 at 10:25 PM, Ami Fischman ...
8 years, 7 months ago (2012-05-22 05:31:53 UTC) #7
Ami GONE FROM CHROMIUM
"OK" does not an lgtm make... :)
8 years, 7 months ago (2012-05-22 08:20:51 UTC) #8
darin (slow to review)
LGTM
8 years, 7 months ago (2012-05-22 18:12:21 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 18:29:02 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698