Move helper functions into the anonymous namespace.

Move helper functions into the anonymous namespace.

In an upcoming CL, yet another extension function type is needed.
Instead of adding yet another Bluetooth specific subclass, I think it
makes more sense to move the three helper functions that are needed
into the anonymous namespace.

TEST=still compiles
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137348

[bryeung, 2012-05-15 19:57:17]

This isn't net LOC negative in this CL, but it is overall with the new type of
extension function I need to add for read/write, so I think overall it's a win.

Thoughts?

[asargent_no_longer_on_chrome, 2012-05-15 20:46:08]

We usually try to avoid macros in favor of templates when possible. But I'm not
sure you need either in this case.

It looks like BluetoothExtensionFunctionHelper actually just needs a Profile*
and not a full UIThreadExtensionFunction. What if you just made the
BluetoothExtensionFunctionHelper  methods take a Profile*, and put them into an
anonymous namespace in the .cc file?

So you'd have:

namespace {

chromeos::ExtensionBluetoothEventRouter* GetEventRouter(Profile* profile) {
  return profile->GetExtensionService()->bluetooth_event_router()
}

const chromeos::BluetoothAdapter* GetAdapter(Profile* profile) const {
  return GetEventRouter(profile)->adapter();
}

...

}  // namespace


...


bool BluetoothIsAvailableFunction::RunImpl() {
  result_.reset(Value::CreateBooleanValue(GetAdapter(profile())->IsPresent());
}

[bryeung, 2012-05-15 21:09:56]

Thanks Antony: that was a great suggestion and really helped snap me out of a
bad way of thinking about this refactoring.

I think this looks much nicer now.

[asargent_no_longer_on_chrome, 2012-05-15 22:01:47]

LGTM

https://chromiumcodereview.appspot.com/10383198/diff/6003/chrome/browser/exte...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.h (right):

https://chromiumcodereview.appspot.com/10383198/diff/6003/chrome/browser/exte...
chrome/browser/extensions/api/bluetooth/bluetooth_api.h:19: class
ExtensionBluetoothEventRouter;
nit: can you get rid of any of these forward declarations?

[commit-bot: I haz the power, 2012-05-15 23:24:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/10383198/4003

[bryeung, 2012-05-15 23:24:15]

https://chromiumcodereview.appspot.com/10383198/diff/6003/chrome/browser/exte...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.h (right):

https://chromiumcodereview.appspot.com/10383198/diff/6003/chrome/browser/exte...
chrome/browser/extensions/api/bluetooth/bluetooth_api.h:19: class
ExtensionBluetoothEventRouter;
On 2012/05/15 22:01:47, Antony Sargent wrote:
> nit: can you get rid of any of these forward declarations?

Good catch.  Done.

[commit-bot: I haz the power, 2012-05-16 03:40:59]

Change committed as 137348