Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10383195: Remove browser_view.h include from extension_browsertests_misc.cc (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Remove browser_view.h include from extension_browsertests_misc.cc BUG=125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/chrome_browser_main_extra_parts_views.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 7 months ago (2012-05-15 19:52:21 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-05-15 20:16:56 UTC) #2
LGTM thanks!

On Tue, May 15, 2012 at 12:52 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Remove browser_view.h include from extension_browsertests_misc.cc
>
> BUG=125846
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10383195/<http://codereview.chromium.org/103...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chrome_browser_**main_extra_parts_views.cc
>  M chrome/browser/extensions/**extension_browsertests_misc.cc
>
>
> Index: chrome/browser/chrome_browser_**main_extra_parts_views.cc
> diff --git a/chrome/browser/chrome_**browser_main_extra_parts_**views.cc
> b/chrome/browser/chrome_**browser_main_extra_parts_**views.cc
> index 15e9461c680f8bfbdab050611faf36**74ae6ac809..**
> fa17bbc09f49fa3f7547f1d2e2af41**099c547c35 100644
> --- a/chrome/browser/chrome_**browser_main_extra_parts_**views.cc
> +++ b/chrome/browser/chrome_**browser_main_extra_parts_**views.cc
> @@ -4,12 +4,7 @@
>
>  #include "chrome/browser/chrome_**browser_main_extra_parts_**views.h"
>
> -#include <string>
> -
> -#include "base/command_line.h"
>  #include "chrome/browser/ui/views/**chrome_views_delegate.h"
> -#include "chrome/common/chrome_**switches.h"
> -#include "ui/views/widget/widget.h"
>
>  ChromeBrowserMainExtraPartsVie**ws::**ChromeBrowserMainExtraPartsVie**
> ws()
>     : ChromeBrowserMainExtraParts() {
> Index: chrome/browser/extensions/**extension_browsertests_misc.cc
> diff --git a/chrome/browser/extensions/**extension_browsertests_misc.cc
> b/chrome/browser/extensions/**extension_browsertests_misc.cc
> index 29bcf4221b6fa1a07886414fefd07e**a3fdb16b25..**
> f0fbe1fc4b92391ca89d2c2e41266c**959ad4dbaa 100644
> --- a/chrome/browser/extensions/**extension_browsertests_misc.cc
> +++ b/chrome/browser/extensions/**extension_browsertests_misc.cc
> @@ -32,10 +32,6 @@
>  #include "net/test/test_server.h"
>  #include "webkit/glue/webpreferences.h"
>
> -#if defined(TOOLKIT_VIEWS)
> -#include "chrome/browser/ui/views/**frame/browser_view.h"
> -#endif
> -
>  using content::NavigationController;
>  using content::WebContents;
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698