Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 10383191: Convert the notifications interactive ui_test to use InProcessBrowserTest, and run it in inside bro… (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Visibility:
Public.

Description

Convert the notifications interactive ui_test to use InProcessBrowserTest, and run it in inside browser_tests target (no need for it to be interactive). BUG=121574, 62311, 74428 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -112 lines) Patch
A + chrome/browser/notifications/notification_browsertest.cc View 1 chunk +28 lines, -41 lines 0 comments Download
D chrome/browser/notifications/notifications_interactive_uitest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 7 months ago (2012-05-15 17:47:09 UTC) #1
Avi (use Gerrit)
8 years, 7 months ago (2012-05-15 17:54:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698