Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 10383186: Add zapping of Map contents in debug mode. (Closed)

Created:
8 years, 7 months ago by Michael Starzinger
Modified:
8 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Add zapping of Map contents in debug mode. This zaps the contents of stale descriptor arrays and prototype transition arrays before overwriting references to them. It should help to discover accidental sharing early and is needed for the heap verifier when map collection with incremental marking lands. R=ulan@chromium.org BUG=v8:1465 Committed: https://code.google.com/p/v8/source/detail?r=11569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/objects.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 7 months ago (2012-05-15 13:47:16 UTC) #1
ulan
8 years, 7 months ago (2012-05-15 14:15:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698