PPAPI/NaCl: Fix leaky NaClIPCAdapter test.

PPAPI/NaCl: Fix leaky NaClIPCAdapter test.

The NaClIPCAdapter was not leaking, but the Channel deletion is posted as a task that the test was not running. This makes all the NaClIPCAdapter test cases do RunAllPending on shutdown to delete stuff. Unfortunately, one of the tests results in calling "Close()" on the channel in one of these tasks, and that fails for IPC::TestSink, because IPC::Channel::Close dereferences channel_impl_ unconditionally, and the channel_impl_ is NULL for TestSink. So this patch also makes Channel::Close() do nothing if channel_impl_ is NULL.

BUG=127954
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137471

[dmichael (off chromium), 2012-05-14 22:15:27]

I'm not sure if this is worth changing ipc_channel_{posix|win}.cc for. We could
just leave the suppresion in and mark the bug WontFix. Alternatively, we could
explicitly delete the Sink, but that wouldn't verify that NaClIPCAdapter deletes
it.

What do you think?

[brettw, 2012-05-16 05:17:29]

lgtm

[commit-bot: I haz the power, 2012-05-16 17:18:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10383167/9001

[commit-bot: I haz the power, 2012-05-16 18:58:36]

Change committed as 137471