Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 10383162: Make sure the thread calling CoCreateGuid is CoInitialized. (Closed)

Created:
8 years, 7 months ago by Sigurður Ásgeirsson
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Make sure the thread calling CoCreateGuid is CoInitialized. BUG=127671 TEST=Test passes on Vista test bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/win/event_trace_consumer_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sigurður Ásgeirsson
Need owners approval. To be clear this is an attempted fix - the only reason ...
8 years, 7 months ago (2012-05-14 17:57:32 UTC) #1
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-14 18:17:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/10383162/1
8 years, 7 months ago (2012-05-14 20:38:55 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-14 22:12:02 UTC) #4
Change committed as 136990

Powered by Google App Engine
This is Rietveld 408576698