Issue 10383154: Fix mode=hashtable without --outdir to create the directory at the right place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383154: Fix mode=hashtable without --outdir to create the directory at the right place. (Closed)

Created:
8 years, 7 months ago by M-A Ruel

Modified:
8 years, 7 months ago

Reviewers:
MAD

CC:
chromium-reviews, pam+watch_chromium.org, csharp, Roger Tawa OOO till Jul 10th

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix mode=hashtable without --outdir to create the directory at the right place. Improve isolate_smoke_test.py to be more representative of what's happening in chromium's gyp files. Fix tests on windows. No need to run Strace tests on Windows, they fail because of os.path.sep differences. TBR=mad@chromium.org BUG=98636 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136814

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -83 lines)			Patch
M	tools/isolate/isolate.py	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	tools/isolate/isolate_smoke_test.py	View	5 chunks	+150 lines, -10 lines	0 comments	Download
M	tools/isolate/trace_inputs_test.py	View	1 chunk	+71 lines, -69 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TBR'ing to fix swarm master. Sorry for the downtime. :(

Expand Messages | Collapse Messages