Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10383152: Add ragel to third_party. (Closed)

Created:
8 years, 7 months ago by khim
Modified:
8 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add ragel to third_party. Different versions of ragel produce slightly different versions of generated code and we commit this code to repository. To stop endless churn it's better to commit one single prebuilt version of ragel to the repo. Includes ragel sources, prebuilt binary and script which builds said binary. Additionally this version includes -GT2 patch which produces faster code on MSVC 2008/2010. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2597 TEST=none Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8673

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -0 lines) Patch
A deps/third_party/ragel/01-ragel-6.7.GT2.patch View 1 2 3 4 1 chunk +276 lines, -0 lines 0 comments Download
A deps/third_party/ragel/COPYING View 1 2 3 4 1 chunk +340 lines, -0 lines 0 comments Download
A deps/third_party/ragel/README.nacl View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
A deps/third_party/ragel/build.sh View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A deps/third_party/ragel/ragel.linux View 1 2 3 4 Binary file 0 comments Download
A deps/third_party/ragel/ragel-6.7.tar.gz View 1 2 3 4 Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
khim
8 years, 7 months ago (2012-05-13 14:06:51 UTC) #1
pasko-google - do not use
Maybe you wanted to solve other problems with this in the future that you did ...
8 years, 7 months ago (2012-05-13 15:40:01 UTC) #2
khim
I meant different kind of churn: different versions of Ragel produce slightly different output (this ...
8 years, 7 months ago (2012-05-13 15:56:49 UTC) #3
pasko-google - do not use
On 2012/05/13 15:56:49, khim wrote: > I meant different kind of churn: different versions of ...
8 years, 7 months ago (2012-05-13 16:05:05 UTC) #4
pasko-google - do not use
I am OK with the general approach. If Mark has feedback/concerns on this, I'd be ...
8 years, 7 months ago (2012-05-13 16:36:15 UTC) #5
khim
https://chromiumcodereview.appspot.com/10383152/diff/1/ragel/COPYING File ragel/COPYING (right): https://chromiumcodereview.appspot.com/10383152/diff/1/ragel/COPYING#newcode1 ragel/COPYING:1: GNU GENERAL PUBLIC LICENSE On 2012/05/13 16:36:15, pasko wrote: ...
8 years, 7 months ago (2012-05-13 16:40:28 UTC) #6
khim
Whatever. Issue closed.
8 years, 7 months ago (2012-05-13 16:57:16 UTC) #7
bradn
This must go in http://src.chromium.org/viewvc/native_client/trunk/deps/third_party/ Proceed manually with svn.
8 years, 7 months ago (2012-05-22 17:02:04 UTC) #8
bradn
8 years, 7 months ago (2012-05-22 17:14:54 UTC) #9
LGTM (assuming commited to svn://svn.chromium.org/chrome/trunk/deps/third_party
instead.

Powered by Google App Engine
This is Rietveld 408576698