Issue 10383128: Prepare for using GYP build on buildbots

Issue 10383128: Prepare for using GYP build on buildbots (Closed)

Created:
8 years, 7 months ago by Jakob Kummerow

Modified:
8 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare for using GYP build on buildbots Committed: https://code.google.com/p/v8/source/detail?r=11546

Patch Set 2 : addressed comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -45 lines)			Patch
A	DEPS	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	Makefile	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	SConstruct	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	build/common.gypi	View		3 chunks	+7 lines, -9 lines	0 comments	Download
M	build/gyp_v8	View		4 chunks	+11 lines, -25 lines	0 comments	Download
M	build/standalone.gypi	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/testcfg.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/big-array-literal.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/test262/testcfg.py	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/check-static-initializers.sh	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	tools/presubmit.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/test-wrapper-gypbuild.py	View		4 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Please take a look. Happy to explain/discuss any of the changes.

8 years, 7 months ago (2012-05-11 10:29:26 UTC) #1

Yang

LGTM with two comments. https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27 DEPS:27: ] Make sure the commit ...

8 years, 7 months ago (2012-05-11 12:07:00 UTC) #2

Jakob Kummerow

8 years, 7 months ago (2012-05-11 12:17:01 UTC) #3

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
On 2012/05/11 12:07:00, Yang wrote:
> Make sure the commit doesn't include the following lines.

Done.

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/10383128/diff/1/test/test262/testcfg.p...
test/test262/testcfg.py:125: archive.extractall(u'\\\\?\\%s' % self.root)
On 2012/05/11 12:07:00, Yang wrote:
> Maybe add a comment here.

Done.

Expand Messages | Collapse Messages