chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 10383114: Rename BrowserInit to StartupBrowserCreator, and move into startup subdir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 10383114: Rename BrowserInit to StartupBrowserCreator, and move into startup subdir. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

===================================================================

--- chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc (revision 136345)

+++ chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc (working copy)

@@ -10,7 +10,7 @@

#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"

#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"

#include "chrome/browser/service/service_process_control.h"

-#include "chrome/browser/ui/browser_init.h"

+#include "chrome/browser/ui/startup/startup_browser_creator.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/cloud_print/cloud_print_proxy_info.h"

#include "chrome/common/pref_names.h"

@@ -188,10 +188,10 @@

bool LaunchBrowser(const CommandLine& command_line, Profile* profile) {

int return_code = 0;

- BrowserInit browser_init;

- return BrowserInit::ProcessCmdLineImpl(command_line, FilePath(), false,

- profile, BrowserInit::Profiles(),

- &return_code, &browser_init);

+ StartupBrowserCreator browser_creator;

+ return StartupBrowserCreator::ProcessCmdLineImpl(

+ command_line, FilePath(), false, profile,

+ StartupBrowserCreator::Profiles(), &return_code, &browser_creator);

}

protected:

@@ -433,7 +433,7 @@

return service;

}

-TEST_F(CloudPrintProxyPolicyTest, StartBrowserInitWithCommandLine) {

+TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) {

TestingPrefService* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

Value::CreateStringValue(std::string()));