Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3058)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 10383114: Rename BrowserInit to StartupBrowserCreator, and move into startup subdir. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.h ('k') | chrome/browser/chromeos/login/login_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
===================================================================
--- chrome/browser/chrome_browser_main.cc (revision 136345)
+++ chrome/browser/chrome_browser_main.cc (working copy)
@@ -79,7 +79,7 @@
#include "chrome/browser/shell_integration.h"
#include "chrome/browser/translate/translate_manager.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_init.h"
+#include "chrome/browser/ui/startup/startup_browser_creator.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager_backend.h"
#include "chrome/common/child_process_logging.h"
#include "chrome/common/chrome_constants.h"
@@ -208,12 +208,12 @@
#endif
}
-void AddFirstRunNewTabs(BrowserInit* browser_init,
+void AddFirstRunNewTabs(StartupBrowserCreator* browser_creator,
const std::vector<GURL>& new_tabs) {
for (std::vector<GURL>::const_iterator it = new_tabs.begin();
it != new_tabs.end(); ++it) {
if (it->is_valid())
- browser_init->AddFirstRunTab(*it);
+ browser_creator->AddFirstRunTab(*it);
}
}
@@ -498,7 +498,7 @@
return true;
}
- BrowserInit::ProcessCommandLineAlreadyRunning(
+ StartupBrowserCreator::ProcessCommandLineAlreadyRunning(
command_line, current_directory);
return true;
}
@@ -1209,7 +1209,7 @@
result_code_ = PreCreateThreadsImpl();
// These members must be initialized before returning from this function.
DCHECK(master_prefs_.get());
- DCHECK(browser_init_.get());
+ DCHECK(browser_creator_.get());
return result_code_;
}
@@ -1267,7 +1267,7 @@
// These members must be initialized before returning from this function.
master_prefs_.reset(new first_run::MasterPrefs);
- browser_init_.reset(new BrowserInit);
+ browser_creator_.reset(new StartupBrowserCreator);
#if !defined(OS_ANDROID)
// Convert active labs into switches. This needs to be done before
@@ -1352,7 +1352,7 @@
if (is_first_run_) {
first_run_ui_bypass_ = !first_run::ProcessMasterPreferences(
user_data_dir_, master_prefs_.get());
- AddFirstRunNewTabs(browser_init_.get(), master_prefs_->new_tabs);
+ AddFirstRunNewTabs(browser_creator_.get(), master_prefs_->new_tabs);
// If we are running in App mode, we do not want to show the importer
// (first run) UI.
@@ -1432,7 +1432,7 @@
// PostProfileInit()
// ... additional setup
// PreBrowserStart()
-// ... browser_init_->Start (OR parameters().ui_task->Run())
+// ... browser_creator_->Start (OR parameters().ui_task->Run())
// PostBrowserStart()
void ChromeBrowserMainParts::PreProfileInit() {
@@ -1826,8 +1826,8 @@
std::vector<Profile*> last_opened_profiles =
g_browser_process->profile_manager()->GetLastOpenedProfiles();
#endif
- if (browser_init_->Start(parsed_command_line(), FilePath(),
- profile_, last_opened_profiles, &result_code)) {
+ if (browser_creator_->Start(parsed_command_line(), FilePath(),
+ profile_, last_opened_profiles, &result_code)) {
#if defined(OS_WIN) || (defined(OS_LINUX) && !defined(OS_CHROMEOS))
// Initialize autoupdate timer. Timer callback costs basically nothing
// when browser is not in persistent mode, so it's OK to let it ride on
@@ -1872,7 +1872,7 @@
} else {
run_message_loop_ = false;
}
- browser_init_.reset();
+ browser_creator_.reset();
PostBrowserStart();
« no previous file with comments | « chrome/browser/chrome_browser_main.h ('k') | chrome/browser/chromeos/login/login_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698