Split the URI library across multiple files.

Split the URI library across multiple files.

Committed: https://code.google.com/p/dart/source/detail?r=7543

[ahe, 2012-05-10 11:42:59]

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/uri.dart
File dart/lib/uri/uri.dart (right):

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/uri.dart#...
dart/lib/uri/uri.dart:7: #source('helpers.dart');
Note: there is no pressing need to add this file. However gram@ has a pending CL
that would be nicer if the VM can support this. So I have only made this split
to test concat_library.py.

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/runtime/tools/con...
File dart/runtime/tools/concat_library.py (right):

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/runtime/tools/con...
dart/runtime/tools/concat_library.py:1: #!/usr/bin/env python
Note: I'm (trying to) use the public Python style guide:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html

[ngeoffray, 2012-05-11 12:41:23]

LGTM

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/helpers.dart
File dart/lib/uri/helpers.dart (right):

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/helpers.d...
dart/lib/uri/helpers.dart:19: } else if ("." == segment) {
consistency: put segment lhs

[ahe, 2012-05-11 12:51:32]

Thank you, Nicolas.

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/helpers.dart
File dart/lib/uri/helpers.dart (right):

https://chromiumcodereview.appspot.com/10383103/diff/1/dart/lib/uri/helpers.d...
dart/lib/uri/helpers.dart:19: } else if ("." == segment) {
On 2012/05/11 12:41:23, ngeoffray wrote:
> consistency: put segment lhs

I did not change this code (but I think I wrote it originally). Let me just send
you a subversion based CL to create this file.

[Siggi Cherem (dart-lang), 2012-05-12 00:33:48]

lgtm