Issue 10383090: mac make & ninja: Remove workaround for OTHER_CPLUSPLUSFLAGS being a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383090: mac make & ninja: Remove workaround for OTHER_CPLUSPLUSFLAGS being a string. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

mac make & ninja: Remove workaround for OTHER_CPLUSPLUSFLAGS being a string. This is now fixed in the upstream gyp files and no longer necessary. Committed: https://code.google.com/p/gyp/source/detail?r=1374

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	pylib/gyp/xcode_emulation.py	View		1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages