Issue 10383088: Declare more functions returing a MaybeObject* with MUST_USE_RESULT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383088: Declare more functions returing a MaybeObject* with MUST_USE_RESULT. (Closed)

Created:
8 years, 7 months ago by fschneider

Modified:
8 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Declare more functions returing a MaybeObject* with MUST_USE_RESULT. No violations found this time. Additionally I changed one function JSDate::GetField that never returns a failure to return a Object* instead. Committed: https://code.google.com/p/v8/source/detail?r=11532

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -89 lines)			Patch
M	src/elements.cc	View	12 chunks	+95 lines, -87 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages