Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10383065: Start creating a MemberSet abstraction, and use it to fold getters/setters into field accesses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 7442)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1549,14 +1549,14 @@
visitFieldGet(HFieldGet node) {
if (node.receiver !== null) {
String name =
- compiler.namer.instanceFieldName(currentLibrary, node.element.name);
+ compiler.namer.instanceFieldName(currentLibrary, node.name);
beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
buffer.add('.');
buffer.add(name);
beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
} else {
- buffer.add(JsNames.getValid(node.element.name.slowToString()));
+ buffer.add(JsNames.getValid(node.name.slowToString()));
}
}
@@ -1564,7 +1564,7 @@
String name;
if (node.receiver !== null) {
name =
- compiler.namer.instanceFieldName(currentLibrary, node.element.name);
+ compiler.namer.instanceFieldName(currentLibrary, node.name);
beginExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
buffer.add('.');
@@ -1572,7 +1572,7 @@
} else {
// TODO(ngeoffray): Remove the 'var' once we don't globally box
// variables used in a try/catch.
- name = JsNames.getValid(node.element.name.slowToString());
+ name = JsNames.getValid(node.name.slowToString());
declareVariable(name);
}
buffer.add(' = ');
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698