Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10383065: Start creating a MemberSet abstraction, and use it to fold getters/setters into field accesses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 7442)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -394,7 +394,7 @@
// itself.
HInstruction receiver = new HThis();
builder.add(receiver);
- HInstruction fieldGet = new HFieldGet(redirect, receiver);
+ HInstruction fieldGet = new HFieldGet(redirect.name, receiver);
builder.add(fieldGet);
return fieldGet;
} else if (isBoxed(element)) {
@@ -406,12 +406,12 @@
// the box.
assert(redirect.enclosingElement.kind == ElementKind.VARIABLE);
HInstruction box = readLocal(redirect.enclosingElement);
- HInstruction lookup = new HFieldGet(redirect, box);
+ HInstruction lookup = new HFieldGet(redirect.name, box);
builder.add(lookup);
return lookup;
} else {
assert(isUsedInTry(element));
- HInstruction variable = new HFieldGet.fromActivation(element);
+ HInstruction variable = new HFieldGet.fromActivation(element.name);
builder.add(variable);
return variable;
}
@@ -448,7 +448,7 @@
// itself.
HInstruction receiver = new HThis();
builder.add(receiver);
- builder.add(new HFieldSet(redirect, receiver, value));
+ builder.add(new HFieldSet(redirect.name, receiver, value));
} else if (isBoxed(element)) {
Element redirect = redirectionMapping[element];
// The box itself could be captured, or be local. A local variable that
@@ -457,10 +457,10 @@
// be accessed directly.
assert(redirect.enclosingElement.kind == ElementKind.VARIABLE);
HInstruction box = readLocal(redirect.enclosingElement);
- builder.add(new HFieldSet(redirect, box, value));
+ builder.add(new HFieldSet(redirect.name, box, value));
} else {
assert(isUsedInTry(element));
- builder.add(new HFieldSet.fromActivation(element,value));
+ builder.add(new HFieldSet.fromActivation(element.name, value));
}
}

Powered by Google App Engine
This is Rietveld 408576698