Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 10383059: Terminate plugins as well as runing onunload handlers during slow shutdown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
===================================================================
--- webkit/plugins/ppapi/ppapi_plugin_instance.h (revision 135720)
+++ webkit/plugins/ppapi/ppapi_plugin_instance.h (working copy)
@@ -124,7 +124,9 @@
// Does some pre-destructor cleanup on the instance. This is necessary
// because some cleanup depends on the plugin instance still existing (like
// calling the plugin's DidDestroy function). This function is called from
- // the WebPlugin implementation when WebKit is about to remove the plugin.
+ // the WebPlugin implementation when WebKit is about to remove the plugin,
+ // and may also be called directly by RenderViewImpl when a clean wekbit
+ // shutdown is being skipped.
void Delete();
// Paints the current backing store to the web page.
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698