Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tests/lib/args/args_test.dart

Issue 10383049: Revert "Using arg parsing lib for dart2js." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/dart2js.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/args/args_test.dart
diff --git a/tests/lib/args/args_test.dart b/tests/lib/args/args_test.dart
index 853558b1585d226ff0e97272ac971a38f04fb089..bddfd84e9e890dd1ad95dedd84590573c9ff67f1 100644
--- a/tests/lib/args/args_test.dart
+++ b/tests/lib/args/args_test.dart
@@ -8,25 +8,6 @@
#import('../../../lib/args/args.dart');
main() {
- group('ArgParser()', () {
- test('adds a help option if includeHelp is true', () {
- var parser = new ArgParser(includeHelp: true);
- var results = parser.parse(['-h']);
- expect(results['help']).isTrue();
- });
-
- test('does not add a help option if includeHelp is false', () {
- var parser = new ArgParser(includeHelp: false);
- throwsBadFormat(parser, ['-h']);
- });
-
- test('includeHelp defaults to true', () {
- var parser = new ArgParser();
- var results = parser.parse(['-h']);
- expect(results['help']).isTrue();
- });
- });
-
group('ArgParser.addFlag()', () {
test('throws IllegalArgumentException if the flag already exists', () {
var parser = new ArgParser();
@@ -399,32 +380,8 @@ main() {
});
group('ArgParser.getUsage()', () {
- test('shows usage if provided', () {
- var parser = new ArgParser(usage: 'myapp [options]');
- parser.addFlag('mode', help: 'The mode');
-
- validateUsage(parser,
- '''
- myapp [options]
-
- -h, --[no-]help Display usage information
- --[no-]mode The mode
- ''');
- });
-
- test('shows help if included', () {
- var parser = new ArgParser(includeHelp: true);
- parser.addFlag('mode', help: 'The mode');
-
- validateUsage(parser,
- '''
- -h, --[no-]help Display usage information
- --[no-]mode The mode
- ''');
- });
-
- test('shows "no-" in flag titles', () {
- var parser = new ArgParser(includeHelp: false);
+ test('flags show "no-" in title', () {
+ var parser = new ArgParser();
parser.addFlag('mode', help: 'The mode');
validateUsage(parser,
@@ -433,8 +390,8 @@ main() {
''');
});
- test('omits the column if there are no abbreviations', () {
- var parser = new ArgParser(includeHelp: false);
+ test('if there are no abbreviations, there is no column for them', () {
+ var parser = new ArgParser();
parser.addFlag('mode', help: 'The mode');
validateUsage(parser,
@@ -443,8 +400,8 @@ main() {
''');
});
- test('lines up options past abbreviations', () {
- var parser = new ArgParser(includeHelp: false);
+ test('options are lined up past abbreviations', () {
+ var parser = new ArgParser();
parser.addFlag('mode', abbr: 'm', help: 'The mode');
parser.addOption('long', help: 'Lacks an abbreviation');
@@ -455,8 +412,8 @@ main() {
''');
});
- test('lines up help text past the longest option', () {
- var parser = new ArgParser(includeHelp: false);
+ test('help text is lined up past the longest option', () {
+ var parser = new ArgParser();
parser.addFlag('mode', abbr: 'm', help: 'Lined up with below');
parser.addOption('a-really-long-name', help: 'Its help text');
@@ -467,8 +424,8 @@ main() {
''');
});
- test('ignores leading empty lines in help text', () {
- var parser = new ArgParser(includeHelp: false);
+ test('leading empty lines are ignored in help text', () {
+ var parser = new ArgParser();
parser.addFlag('mode', help: '\n\n\n\nAfter newlines');
validateUsage(parser,
@@ -477,8 +434,8 @@ main() {
''');
});
- test('ignores trailing empty lines in help text', () {
- var parser = new ArgParser(includeHelp: false);
+ test('trailing empty lines are ignored in help text', () {
+ var parser = new ArgParser();
parser.addFlag('mode', help: 'Before newlines\n\n\n\n');
validateUsage(parser,
@@ -487,8 +444,8 @@ main() {
''');
});
- test('documents options in the order they were added', () {
- var parser = new ArgParser(includeHelp: false);
+ test('options are documented in the order they were added', () {
+ var parser = new ArgParser();
parser.addFlag('zebra', help: 'First');
parser.addFlag('monkey', help: 'Second');
parser.addFlag('wombat', help: 'Third');
@@ -501,8 +458,8 @@ main() {
''');
});
- test('shows the default value for a flag if true', () {
- var parser = new ArgParser(includeHelp: false);
+ test('the default value for a flag is shown if on', () {
+ var parser = new ArgParser();
parser.addFlag('affirm', help: 'Should be on', defaultsTo: true);
parser.addFlag('negate', help: 'Should be off', defaultsTo: false);
@@ -515,8 +472,8 @@ main() {
''');
});
- test('shows the default value for an option with no allowed list', () {
- var parser = new ArgParser(includeHelp: false);
+ test('the default value for an option with no allowed list is shown', () {
+ var parser = new ArgParser();
parser.addOption('any', help: 'Can be anything', defaultsTo: 'whatevs');
validateUsage(parser,
@@ -526,8 +483,8 @@ main() {
''');
});
- test('shows the allowed list', () {
- var parser = new ArgParser(includeHelp: false);
+ test('the allowed list is shown', () {
+ var parser = new ArgParser();
parser.addOption('suit', help: 'Like in cards',
allowed: ['spades', 'clubs', 'hearts', 'diamonds']);
@@ -538,8 +495,8 @@ main() {
''');
});
- test('highlights the default in the allowed list', () {
- var parser = new ArgParser(includeHelp: false);
+ test('the default is highlighted in the allowed list', () {
+ var parser = new ArgParser();
parser.addOption('suit', help: 'Like in cards', defaultsTo: 'clubs',
allowed: ['spades', 'clubs', 'hearts', 'diamonds']);
@@ -550,8 +507,8 @@ main() {
''');
});
- test('shows the allowed help', () {
- var parser = new ArgParser(includeHelp: false);
+ test('the allowed help is shown', () {
+ var parser = new ArgParser();
parser.addOption('suit', help: 'Like in cards', defaultsTo: 'clubs',
allowed: ['spades', 'clubs', 'diamonds', 'hearts'],
allowedHelp: {
« no previous file with comments | « lib/compiler/implementation/dart2js.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698