Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 10383044: MIPS: Fixed illegal instruction use on Loongson in code for Math.random(). (Closed)

Created:
8 years, 7 months ago by palfia
Modified:
8 years, 7 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fixed illegal instruction use on Loongson in code for Math.random(). BUG=v8:2115 TEST=mjsunit/string-case,mjsunit/regress/regress-110509,mjsunit/math-floor Committed: https://code.google.com/p/v8/source/detail?r=11523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
This patch fixes issue: http://code.google.com/p/v8/issues/detail?id=2115
8 years, 7 months ago (2012-05-07 15:50:50 UTC) #1
Paul Lind
On 2012/05/07 15:50:50, palfia wrote: > This patch fixes issue: http://code.google.com/p/v8/issues/detail?id=2115 The code change LGTM. ...
8 years, 7 months ago (2012-05-07 15:58:00 UTC) #2
palfia
On 2012/05/07 15:58:00, Paul Lind wrote: > On 2012/05/07 15:50:50, palfia wrote: > > This ...
8 years, 7 months ago (2012-05-07 16:23:42 UTC) #3
Yang
8 years, 7 months ago (2012-05-07 17:27:05 UTC) #4
On 2012/05/07 16:23:42, palfia wrote:
> On 2012/05/07 15:58:00, Paul Lind wrote:
> > On 2012/05/07 15:50:50, palfia wrote:
> > > This patch fixes issue: http://code.google.com/p/v8/issues/detail?id=2115
> > 
> > The code change LGTM. There are some style issues with the submission,
please
> > update:
> > 
> > 1. Word 'instruction' in issue title is mis-spelled.
> > 2. We use "MIPS: " in prefix for code submissions, not "[MIPS]"
> > 3. The issue provides place for BUG= to specify the v8 issue being fixed,
and
> > TEST= to document (at least one) failing test, if there is one. Please
update
> > these fields.
> 
> Done.

LGTM. Landing.

Powered by Google App Engine
This is Rietveld 408576698