runtime/bin/http_impl.dart - Issue 10383039: Implemented W3C complient web socket client interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_impl.dart

Issue 10383039: Implemented W3C complient web socket client interface (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of comments from ager@ Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/http_impl.dart

diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart

index 785fc93429bfae4842daab2a4336f5db30af2317..435d9f402812ff00000d508b6be8a3ca5a1db390 100644

--- a/runtime/bin/http_impl.dart

+++ b/runtime/bin/http_impl.dart

@@ -1439,6 +1439,7 @@ class _HttpClient implements HttpClient {

}

_HttpClientConnection connection = new _HttpClientConnection(this);

+ connection.onDetach = () => _activeSockets.remove(connection._socketConn);

// If there are active connections for this key get the first one

// otherwise create a new one.

« no previous file with comments | « no previous file | runtime/bin/websocket.dart » ('j') | runtime/bin/websocket.dart » ('J')