owners.py - Issue 10383038: Fix crash in owners.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: owners.py

Issue 10383038: Fix crash in owners.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: owners.py

diff --git a/owners.py b/owners.py

index a7067cba4e9915413572616645eb1b45d0703abc..d3028a593462177d881456d357f478273c63c831 100644

--- a/owners.py

+++ b/owners.py

@@ -215,6 +215,7 @@ class Database(object):

# Remove all directories owned by the current owner from the remaining

# list.

for dirname in owned_dirs[max_owner]:

- dirs.remove(dirname)

+ if dirname in dirs:

+ dirs.remove(dirname)

return final_owners

« no previous file with comments | « no previous file | no next file » | no next file with comments »