Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: webkit/tools/test_shell/test_shell_win.cc

Issue 10383006: Add scale factor and 2x resources from webkit and plumb through to ContentClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more test class GetImageResource methods. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/test_shell_webkit_init.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_win.cc
diff --git a/webkit/tools/test_shell/test_shell_win.cc b/webkit/tools/test_shell/test_shell_win.cc
index a5b1d8cf76cbd4739fa09004a64cf74cd28426d3..b07c26d532263bd83f34bb3a0449c25cff4ed22d 100644
--- a/webkit/tools/test_shell/test_shell_win.cc
+++ b/webkit/tools/test_shell/test_shell_win.cc
@@ -669,8 +669,13 @@ string16 TestShellWebKitInit::GetLocalizedString(int message_id) {
return string16(localized, length);
}
-// TODO(tc): Convert this to using resources from test_shell.rc.
base::StringPiece TestShellWebKitInit::GetDataResource(int resource_id) {
+ return base::StringPiece();
+}
+
+// TODO(tc): Convert this to using resources from test_shell.rc.
+base::StringPiece TestShellWebKitInit::GetImageResource(int resource_id,
+ float scale_factor) {
switch (resource_id) {
case IDR_BROKENIMAGE: {
// Use webkit's broken image icon (16x16)
@@ -714,6 +719,7 @@ base::StringPiece TestShellWebKitInit::GetDataResource(int resource_id) {
case IDR_INPUT_SPEECH:
case IDR_INPUT_SPEECH_RECORDING:
case IDR_INPUT_SPEECH_WAITING:
+ //TODO(flackr): Pass scale_factor.
return TestShell::ResourceProvider(resource_id);
default:
« no previous file with comments | « webkit/tools/test_shell/test_shell_webkit_init.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698