Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2156)

Issue 10382238: Change the test_isolation_outdir default from PRODUCT_DIR to PRODUCT_DIR/isolate (Closed)

Created:
8 years, 7 months ago by M-A Ruel
Modified:
8 years, 7 months ago
Reviewers:
MAD
CC:
chromium-reviews, csharp
Base URL:
bombe.local:src/chrome/src@13_fix_unit_tests_run
Visibility:
Public.

Description

Change the test_isolation_outdir default from PRODUCT_DIR to PRODUCT_DIR/isolate Otherwise a lot of spew is generated when using test_isolation_mode=hashtable. Do not use hashtable since outdir is also used with _run and _remap. R=mad@chromium.org BUG=98636 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
8 years, 7 months ago (2012-05-18 15:49:29 UTC) #1
MAD
8 years, 7 months ago (2012-05-18 17:30:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698