Issue 10382220: Adds favicon and thumbnail columns to the chrome://suggestions-internals/ page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382220: Adds favicon and thumbnail columns to the chrome://suggestions-internals/ page. (Closed)

Created:
8 years, 7 months ago by macourteau

Modified:
8 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews), beaudoin, Rune Fevang

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adds favicon and thumbnail columns to the chrome://suggestions-internals/ page. BUG=none TEST=Visit the chrome://suggestions-internals/ page, and make sure that the favicon and thumbnail columns are present, and that they contain data in at least some cells. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137716

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	chrome/browser/resources/suggestions_internals/suggestions_internals.js	View		2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/10382220/1

8 years, 7 months ago (2012-05-17 18:29:45 UTC) #3

Change committed as 137716

Expand Messages | Collapse Messages