Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 10382217: Merge 117307 - Avoid jumpscroll when entering new text in a multi-line editor. (Closed)

Created:
8 years, 7 months ago by mnaganov (inactive)
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 117307 - Avoid jumpscroll when entering new text in a multi-line editor. https://bugs.webkit.org/show_bug.cgi?id=82875 Reviewed by Ryosuke Niwa Scroll caret to the edge of the viewport in case if a line break or a paragraph separator is inserted at the end of a multi-line editor. This avoids undesirable jumpscroll in cases when there is content under the editor. Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html * editing/Editor.cpp: (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::revealSelectionAfterEditingOperation): * editing/Editor.h: (Editor): * editing/input/resources/reveal-utilities.js: (performJumpAtTheEdgeTest): * editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added. * editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added. * editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added. * editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added. * editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added. * editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added. TBR=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117419

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
mnaganov (inactive)
8 years, 7 months ago (2012-05-17 09:22:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698