Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10382216: Remove browser-actions-for-all flag and replace funcionality with action-box. (Closed)

Created:
8 years, 7 months ago by not at google - send to devlin
Modified:
8 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Remove browser-actions-for-all flag and replace funcionality with action-box. This removes the behaviour where browser actions get generated if missing, but maintains the behaviour of page actions becoming browser actions if the action box is enabled. BUG=127988 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137639

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix flag names #

Patch Set 3 : Needed to pin the browser action #

Patch Set 4 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -48 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 5 chunks +5 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
8 years, 7 months ago (2012-05-17 03:57:37 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/10382216/diff/1/chrome/browser/extensions/api/extension_action/extension_actions_api.cc File chrome/browser/extensions/api/extension_action/extension_actions_api.cc (right): http://codereview.chromium.org/10382216/diff/1/chrome/browser/extensions/api/extension_action/extension_actions_api.cc#newcode161 chrome/browser/extensions/api/extension_action/extension_actions_api.cc:161: // If --extension-action-box is enabled there will be ...
8 years, 7 months ago (2012-05-17 04:34:29 UTC) #2
not at google - send to devlin
http://codereview.chromium.org/10382216/diff/1/chrome/browser/extensions/api/extension_action/extension_actions_api.cc File chrome/browser/extensions/api/extension_action/extension_actions_api.cc (right): http://codereview.chromium.org/10382216/diff/1/chrome/browser/extensions/api/extension_action/extension_actions_api.cc#newcode161 chrome/browser/extensions/api/extension_action/extension_actions_api.cc:161: // If --extension-action-box is enabled there will be a ...
8 years, 7 months ago (2012-05-17 04:38:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10382216/4002
8 years, 7 months ago (2012-05-17 04:38:30 UTC) #4
commit-bot: I haz the power
Try job failure for 10382216-4002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-17 05:27:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10382216/6003
8 years, 7 months ago (2012-05-17 06:32:07 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 08:01:11 UTC) #7 
Change committed as 137639

Powered by Google App Engine
This is Rietveld 408576698