Issue 10382211: chromeos: Ignore power button presses when screen is off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382211: chromeos: Ignore power button presses when screen is off. (Closed)

Created:
8 years, 7 months ago by Daniel Erat

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Ignore power button presses when screen is off. Make PowerButtonController ignore power button events when the screen is turned off -- if the user hits the power button to turn the screen back on, we don't want to lock or shutdown if they hold it a bit too long. BUG=128451 TEST=added, also did manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137679

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -2 lines)			Patch
M	ash/wm/power_button_controller.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ash/wm/power_button_controller.cc	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	ash/wm/power_button_controller_unittest.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/power/brightness_observer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/power/brightness_observer.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10382211/1

8 years, 7 months ago (2012-05-17 16:03:44 UTC) #3

Change committed as 137679

Expand Messages | Collapse Messages