Issue 10382203: Split the nssckbi target off from the 'nss' target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382203: Split the nssckbi target off from the 'nss' target. (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi

Modified:
8 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/nss

Visibility:
Public.

More Reviews

Description

Split the nssckbi target off from the 'nss' target. Originally reviewed at http://codereview.chromium.org/10392098/ BUG=123666 TEST=it compiles (both static and shared) TBR=wtc

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -71 lines)			Patch
	M	nss.gyp	View		9 chunks	+127 lines, -71 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

TBR. Had to update the Base URL for the review, which requires creating a new ...

8 years, 7 months ago (2012-05-16 19:15:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10382203/1

8 years, 7 months ago (2012-05-16 19:15:26 UTC) #3

wtc

8 years, 7 months ago (2012-05-16 19:45:10 UTC) #5

LGTM.

https://chromiumcodereview.appspot.com/10382203/diff/1/nss.gyp
File nss.gyp (right):

https://chromiumcodereview.appspot.com/10382203/diff/1/nss.gyp#newcode339
nss.gyp:339: 'mozilla/security/nss/lib/nss/nssver.c',

It would be nice to add a comment to explain why the nss
target contains only this file from the NSS source tree.
From your original CL:

  A bit of a hack to ensure at least one symbol is linked
  in to the target. MSVC gets grumpy if a target has no
  linkables but tries to produce a DLL (line 344)

Expand Messages | Collapse Messages