media/webm/webm_cluster_parser_unittest.cc - Issue 10382200: Update WebMClusterParser to compute durations for all StreamParserBuffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/webm/webm_cluster_parser_unittest.cc

Issue 10382200: Update WebMClusterParser to compute durations for all StreamParserBuffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/webm/webm_cluster_parser_unittest.cc

diff --git a/media/webm/webm_cluster_parser_unittest.cc b/media/webm/webm_cluster_parser_unittest.cc

index d553c1da81db6e19178c6d0db0a4c164832d6992..cbf3150b50e180cb3b66663f8ca9d1008fdcb79e 100644

--- a/media/webm/webm_cluster_parser_unittest.cc

+++ b/media/webm/webm_cluster_parser_unittest.cc

@@ -38,11 +38,11 @@ struct BlockInfo {

};

const BlockInfo kDefaultBlockInfo[] = {

- { kAudioTrackNum, 0, -1, true },

- { kAudioTrackNum, 23, -1, true },

+ { kAudioTrackNum, 0, 23, true },

+ { kAudioTrackNum, 23, 23, true },

{ kVideoTrackNum, kVideoDefaultDurationInMs, kVideoDefaultDurationInMs,

true },

- { kAudioTrackNum, 46, -1, true },

+ { kAudioTrackNum, 46, 23, false },

{ kVideoTrackNum, 2 * kVideoDefaultDurationInMs, kVideoDefaultDurationInMs,

true },

};

@@ -242,7 +242,7 @@ TEST_F(WebMClusterParserTest, ParseBlockGroup) {

TEST_F(WebMClusterParserTest, ParseSimpleBlockAndBlockGroupMixture) {

const BlockInfo kBlockInfo[] = {

- { kAudioTrackNum, 0, -1, true },

+ { kAudioTrackNum, 0, 23, true },

{ kAudioTrackNum, 23, 23, false },

{ kVideoTrackNum, kVideoDefaultDurationInMs, kVideoDefaultDurationInMs,

true },

« no previous file with comments | « media/webm/webm_cluster_parser.cc ('k') | media/webm/webm_tracks_parser.cc » ('j') | no next file with comments »