Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: media/webm/webm_cluster_parser.h

Issue 10382200: Update WebMClusterParser to compute durations for all StreamParserBuffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/pipeline_integration_test.cc ('k') | media/webm/webm_cluster_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/webm/webm_cluster_parser.h
diff --git a/media/webm/webm_cluster_parser.h b/media/webm/webm_cluster_parser.h
index 806e2762e657301ea1112b3f4b66f48fb79683d8..851f95cdda7219e6b61d942eec456affdb0f1dbb 100644
--- a/media/webm/webm_cluster_parser.h
+++ b/media/webm/webm_cluster_parser.h
@@ -38,10 +38,34 @@ class MEDIA_EXPORT WebMClusterParser : public WebMParserClient {
// Returns the number of bytes parsed on success.
int Parse(const uint8* buf, int size);
- const BufferQueue& audio_buffers() const { return audio_buffers_; }
- const BufferQueue& video_buffers() const { return video_buffers_; }
+ const BufferQueue& audio_buffers() const { return audio_.buffers(); }
+ const BufferQueue& video_buffers() const { return video_.buffers(); }
private:
+ // Helper class that manages per-track state.
+ class Track {
+ public:
+ Track(int track_num, base::TimeDelta default_duration);
+ ~Track();
+
+ int track_num() const { return track_num_; }
+ const BufferQueue& buffers() const { return buffers_; }
+
+ bool AddBuffer(const scoped_refptr<StreamParserBuffer>& buffer);
+
+ // Clears all buffer state.
+ void Reset();
+
+ // Clears only the |buffers_|.
+ void ClearBufferQueue();
+
+ private:
+ int track_num_;
+ base::TimeDelta default_duration_;
+ BufferQueue buffers_;
+ scoped_refptr<StreamParserBuffer> delayed_buffer_;
+ };
+
// WebMParserClient methods.
virtual WebMParserClient* OnListStart(int id) OVERRIDE;
virtual bool OnListEnd(int id) OVERRIDE;
@@ -54,10 +78,6 @@ class MEDIA_EXPORT WebMClusterParser : public WebMParserClient {
double timecode_multiplier_; // Multiplier used to convert timecodes into
// microseconds.
- int audio_track_num_;
- base::TimeDelta audio_default_duration_;
- int video_track_num_;
- base::TimeDelta video_default_duration_;
scoped_array<uint8> video_encryption_key_id_;
int video_encryption_key_id_size_;
@@ -69,8 +89,9 @@ class MEDIA_EXPORT WebMClusterParser : public WebMParserClient {
int64 block_duration_;
int64 cluster_timecode_;
- BufferQueue audio_buffers_;
- BufferQueue video_buffers_;
+
+ Track audio_;
+ Track video_;
DISALLOW_IMPLICIT_CONSTRUCTORS(WebMClusterParser);
};
« no previous file with comments | « media/filters/pipeline_integration_test.cc ('k') | media/webm/webm_cluster_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698