Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: sync/protocol/session_specifics.proto

Issue 10382183: [Sync] Move PageTransitions enums to SyncEnums (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/protocol/proto_enum_conversions_unittest.cc ('k') | sync/protocol/sync_enums.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/session_specifics.proto
diff --git a/sync/protocol/session_specifics.proto b/sync/protocol/session_specifics.proto
index 43892435ccbb8b3067979cf841897835e5cba8cf..c00b8a01e23fe78f830ccb291694d0447c5c7255 100644
--- a/sync/protocol/session_specifics.proto
+++ b/sync/protocol/session_specifics.proto
@@ -14,6 +14,8 @@ option retain_unknown_fields = true;
package sync_pb;
+import "sync_enums.proto";
+
message SessionSpecifics {
// Unique id for the client.
optional string session_tag = 1;
@@ -103,29 +105,8 @@ message TabNavigation {
// state of the page. This includes form entries and scroll position for each
// frame.
optional string state = 5;
- // Types of transitions between pages.
- enum PageTransition {
- LINK = 0;
- TYPED = 1;
- AUTO_BOOKMARK = 2;
- AUTO_SUBFRAME = 3;
- MANUAL_SUBFRAME = 4;
- GENERATED = 5;
- START_PAGE = 6;
- FORM_SUBMIT = 7;
- RELOAD = 8;
- KEYWORD = 9;
- KEYWORD_GENERATED = 10;
- CHAIN_START = 12;
- CHAIN_END = 13;
- }
- // These qualifiers further define the transition.
- enum PageTransitionQualifier {
- CLIENT_REDIRECT = 1;
- SERVER_REDIRECT = 2;
- }
- optional PageTransition page_transition = 6 [default = TYPED];
- optional PageTransitionQualifier navigation_qualifier = 7;
+ optional SyncEnums.PageTransition page_transition = 6 [default = TYPED];
+ optional SyncEnums.PageTransitionQualifier navigation_qualifier = 7;
// The unique navigation id (within this client).
optional int32 unique_id = 8;
// Timestamp for when this navigation last occurred (in client time).
« no previous file with comments | « sync/protocol/proto_enum_conversions_unittest.cc ('k') | sync/protocol/sync_enums.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698