Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 10382183: [Sync] Move PageTransitions enums to SyncEnums (Closed)

Created:
8 years, 7 months ago by Nicolas Zea
Modified:
8 years, 7 months ago
Reviewers:
rlarocque
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] Move PageTransitions enums to SyncEnums BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137309

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -85 lines) Patch
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 chunks +31 lines, -33 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/proto_enum_conversions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/protocol/proto_enum_conversions.cc View 1 chunk +19 lines, -19 lines 0 comments Download
M sync/protocol/proto_enum_conversions_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/protocol/session_specifics.proto View 2 chunks +4 lines, -23 lines 0 comments Download
M sync/protocol/sync_enums.proto View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
PTAL (this is being done to match server-side changes)
8 years, 7 months ago (2012-05-15 21:17:48 UTC) #1
rlarocque
On 2012/05/15 21:17:48, nzea wrote: > PTAL (this is being done to match server-side changes) ...
8 years, 7 months ago (2012-05-15 21:23:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10382183/7001
8 years, 7 months ago (2012-05-15 22:10:56 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 00:01:04 UTC) #4
Change committed as 137309

Powered by Google App Engine
This is Rietveld 408576698