Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7980)

Unified Diff: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

Issue 10382178: Use single "modifiers" field rather than boolean fields. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
diff --git a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
index 616bf59aa0886b6d4e7e32e36ed795c8564bca93..4774b4c5610f37e1f9b7477a764c9cfb6ff32c4c 100644
--- a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
+++ b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/ui/views/keyboard_overlay_delegate.h"
#include "content/public/browser/native_web_keyboard_event.h"
#include "grit/generated_resources.h"
+#include "ui/base/events.h"
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/screen.h"
@@ -22,13 +23,11 @@
namespace {
struct Accelerator {
ui::KeyboardCode keycode;
- bool shift_pressed;
- bool ctrl_pressed;
- bool alt_pressed;
-} kCloseAccelerators[] = {
- {ui::VKEY_OEM_2, false, true, true},
- {ui::VKEY_OEM_2, true, true, true},
- {ui::VKEY_ESCAPE, true, false, false},
+ int modifiers;
+} const kCloseAccelerators[] = {
+ {ui::VKEY_OEM_2, ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_OEM_2, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN},
};
} // namespace
@@ -47,20 +46,16 @@ KeyboardOverlayDialogView::~KeyboardOverlayDialogView() {
void KeyboardOverlayDialogView::RegisterDialogAccelerators() {
for (size_t i = 0; i < arraysize(kCloseAccelerators); ++i) {
ui::Accelerator accelerator(kCloseAccelerators[i].keycode,
- kCloseAccelerators[i].shift_pressed,
- kCloseAccelerators[i].ctrl_pressed,
- kCloseAccelerators[i].alt_pressed);
+ kCloseAccelerators[i].modifiers);
close_accelerators_.insert(accelerator);
AddAccelerator(accelerator);
}
for (size_t i = 0; i < browser::kAcceleratorMapLength; ++i) {
ui::Accelerator accelerator(browser::kAcceleratorMap[i].keycode,
- browser::kAcceleratorMap[i].shift_pressed,
- browser::kAcceleratorMap[i].ctrl_pressed,
- browser::kAcceleratorMap[i].alt_pressed);
+ browser::kAcceleratorMap[i].modifiers);
// Skip a sole ALT key since it's handled on the keyboard overlay.
- if (ui::Accelerator(ui::VKEY_MENU, false, false, false) == accelerator) {
+ if (ui::Accelerator(ui::VKEY_MENU, ui::EF_NONE) == accelerator) {
continue;
}
// Skip accelerators for closing the dialog since they are already added.
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698