Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/views/accelerator_table_unittest.cc

Issue 10382178: Use single "modifiers" field rather than boolean fields. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/accelerator_table_unittest.cc
diff --git a/chrome/browser/ui/views/accelerator_table_unittest.cc b/chrome/browser/ui/views/accelerator_table_unittest.cc
index 1451dfa5a7d8c2696e016512891ef4c0fc626ffd..070c4c1eee638d28db0d55d3aae0b39587222681 100644
--- a/chrome/browser/ui/views/accelerator_table_unittest.cc
+++ b/chrome/browser/ui/views/accelerator_table_unittest.cc
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "chrome/browser/ui/views/accelerator_table.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/events.h"
#if defined(USE_ASH)
#include "ash/accelerators/accelerator_table.h"
@@ -19,11 +20,7 @@ struct Cmp {
const browser::AcceleratorMapping& rhs) {
if (lhs.keycode != rhs.keycode)
return lhs.keycode < rhs.keycode;
- if (lhs.shift_pressed != rhs.shift_pressed)
- return lhs.shift_pressed < rhs.shift_pressed;
- if (lhs.ctrl_pressed != rhs.ctrl_pressed)
- return lhs.ctrl_pressed < rhs.ctrl_pressed;
- return lhs.alt_pressed < rhs.alt_pressed;
+ return lhs.modifiers < rhs.modifiers;
// Do not check |command_id|.
}
};
@@ -36,8 +33,9 @@ TEST(AcceleratorTableTest, CheckDuplicatedAccelerators) {
const browser::AcceleratorMapping& entry = browser::kAcceleratorMap[i];
EXPECT_TRUE(acclerators.insert(entry).second)
<< "Duplicated accelerator: " << entry.keycode << ", "
- << entry.shift_pressed << ", " << entry.ctrl_pressed << ", "
- << entry.alt_pressed;
+ << (entry.modifiers & ui::EF_SHIFT_DOWN) << ", "
+ << (entry.modifiers & ui::EF_CONTROL_DOWN) << ", "
+ << (entry.modifiers & ui::EF_ALT_DOWN);
}
}
@@ -54,14 +52,13 @@ TEST(AcceleratorTableTest, CheckDuplicatedAcceleratorsAsh) {
continue; // kAcceleratorMap does not have any release accelerators.
browser::AcceleratorMapping entry;
entry.keycode = ash_entry.keycode;
- entry.shift_pressed = ash_entry.shift;
- entry.ctrl_pressed = ash_entry.ctrl;
- entry.alt_pressed = ash_entry.alt;
+ entry.modifiers = ash_entry.modifiers;
entry.command_id = 0; // dummy
EXPECT_TRUE(acclerators.insert(entry).second)
<< "Duplicated accelerator: " << entry.keycode << ", "
- << entry.shift_pressed << ", " << entry.ctrl_pressed << ", "
- << entry.alt_pressed;
+ << (entry.modifiers & ui::EF_SHIFT_DOWN) << ", "
+ << (entry.modifiers & ui::EF_CONTROL_DOWN) << ", "
+ << (entry.modifiers & ui::EF_ALT_DOWN);
}
}
#endif // USE_ASH
« no previous file with comments | « chrome/browser/ui/views/accelerator_table.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698