Issue 10382178: Use single "modifiers" field rather than boolean fields.

Issue 10382178: Use single "modifiers" field rather than boolean fields. (Closed)

Created:
8 years, 7 months ago by Jun Mukai

Modified:
8 years, 7 months ago

Reviewers:
Yusuke Sato, Ben Goodger (Google)

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, derat+watch_chromium.org, ben+watch_chromium.org, mazda

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use single "modifiers" field rather than boolean fields. BUG=128199 TEST=aura_shell_unittests passed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137474

Patch Set 3 : chrome/browser/ui/views fix #

Patch Set 5 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -229 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1	2 chunks	+91 lines, -78 lines	0 comments	Download
M	ash/accelerators/accelerator_table_unittest.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table.h	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table.cc	View	1 2 3 4	2 chunks	+118 lines, -106 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table_unittest.cc	View	1 2 3	4 chunks	+9 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_dialog_view.cc	View	1 2 3 4	3 chunks	+9 lines, -14 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Jun Mukai

Ugha, trybot told me that ash accelerator_table is used under chrome/browser/ui/views. Patchset 3 fixed that ...

8 years, 7 months ago (2012-05-15 21:06:45 UTC) #3

Yusuke Sato

lgtm http://codereview.chromium.org/10382178/diff/4006/chrome/browser/ui/views/accelerator_table.cc File chrome/browser/ui/views/accelerator_table.cc (right): http://codereview.chromium.org/10382178/diff/4006/chrome/browser/ui/views/accelerator_table.cc#newcode19 chrome/browser/ui/views/accelerator_table.cc:19: // Keycode Shift Ctrl Alt Command ID nit: ...

8 years, 7 months ago (2012-05-16 11:02:08 UTC) #5

Jun Mukai

http://codereview.chromium.org/10382178/diff/4006/chrome/browser/ui/views/accelerator_table.cc File chrome/browser/ui/views/accelerator_table.cc (right): http://codereview.chromium.org/10382178/diff/4006/chrome/browser/ui/views/accelerator_table.cc#newcode19 chrome/browser/ui/views/accelerator_table.cc:19: // Keycode Shift Ctrl Alt Command ID On 2012/05/16 ...

8 years, 7 months ago (2012-05-16 17:10:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10382178/14001

8 years, 7 months ago (2012-05-16 17:19:44 UTC) #7

Change committed as 137474

Expand Messages | Collapse Messages