runtime/lib/date.dart - Issue 10382171: Make most arguments to Date constructor optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/date.dart

Issue 10382171: Make most arguments to Date constructor optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/date.dart

diff --git a/runtime/lib/date.dart b/runtime/lib/date.dart

index dc69834bd167e91e47acffbcd361336fc2471927..c670ab32ac41c05326605c4448db9eaf4c7c8509 100644

--- a/runtime/lib/date.dart

+++ b/runtime/lib/date.dart

@@ -18,12 +18,12 @@ class TimeZoneImplementation implements TimeZone {

// JavaScript implementation of DateImplementation.

class DateImplementation implements Date {

factory DateImplementation(int years,

- int month,

- int day,

- int hours,

- int minutes,

- int seconds,

- int milliseconds) {

+ [int month = 1,

+ int day = 1,

+ int hours = 0,

+ int minutes = 0,

+ int seconds = 0,

+ int milliseconds = 0]) {

return new DateImplementation.withTimeZone(

years, month, day,

hours, minutes, seconds, milliseconds,

« no previous file with comments | « lib/compiler/implementation/lib/mockimpl.dart ('k') | tests/corelib/date_time5_test.dart » ('j') | no next file with comments »