Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: corelib/src/date.dart

Issue 10382171: Make most arguments to Date constructor optional. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/lib/date_implementation.dart » ('j') | runtime/lib/date.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/date.dart
diff --git a/corelib/src/date.dart b/corelib/src/date.dart
index c7b5668baaf6ece57186d95a9a5fe01576f26644..5bbfb1d21d368d49fc4ce0ff27e86cf6ae765a69 100644
--- a/corelib/src/date.dart
+++ b/corelib/src/date.dart
@@ -36,13 +36,15 @@ interface Date extends Comparable, Hashable default DateImplementation {
* Constructs a [Date] instance based on the individual parts, in the
* local time-zone.
*/
+ // TODO(floitsch): the spec allows default values in interfaces, but our
+ // our tools don't yet. Eventually we want to have default values here.
ngeoffray 2012/05/15 12:17:35 our our -> our
floitsch 2012/05/15 12:34:22 Done.
Date(int year,
- int month,
sorinmocanu 2012/05/15 12:21:59 Where will you document the possible combinations
floitsch 2012/05/15 12:34:22 Each argument has a default value. 1 for month and
- int day,
- int hours,
- int minutes,
- int seconds,
- int milliseconds);
+ [int month,
+ int day,
+ int hours,
+ int minutes,
+ int seconds,
+ int milliseconds]);
/**
* Constructs a [Date] instance based on the individual parts.
« no previous file with comments | « no previous file | frog/lib/date_implementation.dart » ('j') | runtime/lib/date.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698