Fix for broken CertificateViewerUITest.testDetails.

chrome/browser/resources/certificate_viewer.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cert_viewer', function() {
   'use strict';
 
   /**
    * Initialize the certificate viewer dialog by wiring up the close button,
    * substituting in translated strings and requesting certificate details.
    */
   function initialize() {
     cr.ui.decorate('tabbox', cr.ui.TabBox);
 
     i18nTemplate.process(document, templateData);
 
     var args = JSON.parse(chrome.dialogArguments);
     getCertificateInfo(args);
 
     // The second tab's contents aren't visible on startup, so we can
     // shorten startup by not populating those controls until after we
     // have had a chance to draw the visible controls the first time.
     // The value of 200ms is quick enough that the user couldn't open the
     // tab in that time but long enough to allow the first tab to draw on
     // even the slowest machine.
-    setTimeout(function() {
+
+    function initSecondTab() {
       initializeTree($('hierarchy'), showCertificateFields);
       initializeTree($('cert-fields'), showCertificateFieldValue);
       createCertificateHierarchy(args.hierarchy);
-    }, 200);
+    }
+
+    // When running as a unit-test, don't delay because it introduces
+    // a race-condition and makes the test flakey.

[flackr, 2012/05/17 02:28:16]

It seems to me like the ideal way to fix this would be to make the test
explicitly switch to the details tab, and to make switching to the details tab
force the tab to be initialized if done before the timeout fires cancelling the
timeout. This way we wouldn't have special testing behaviour and in the event
that either the user manages to switch to the second tab before the timeout
fires or we have some code path that loads the second tab on startup everything
works.

+    if (typeof CertificateViewerUITest !== 'undefined')
+      initSecondTab();
+    else
+      setTimeout(initSecondTab, 200);
 
     stripGtkAccessorKeys();
 
     $('export').onclick = exportCertificate;
 
     // TODO(kochi): ESC key should be handled in the views window side.
     document.addEventListener('keydown', function(e) {
       if (e.keyCode == 27)  // ESC
         chrome.send('DialogClose');
     });
@@ skipping 143 matching lines @@
       chrome.send('exportCertificate', [item.detail.payload.index]);
   }
 
   return {
     initialize: initialize,
     getCertificateFields: getCertificateFields,
   };
 });
 
 document.addEventListener('DOMContentLoaded', cert_viewer.initialize);