Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 10382144: Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkia (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar_view.h" 5 #include "chrome/browser/ui/views/toolbar_view.h"
6 6
7 #include "base/i18n/number_formatting.h" 7 #include "base/i18n/number_formatting.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 #endif 742 #endif
743 } 743 }
744 744
745 int ToolbarView::PopupTopSpacing() const { 745 int ToolbarView::PopupTopSpacing() const {
746 return GetWidget()->ShouldUseNativeFrame() ? 0 : kPopupTopSpacingNonGlass; 746 return GetWidget()->ShouldUseNativeFrame() ? 0 : kPopupTopSpacingNonGlass;
747 } 747 }
748 748
749 void ToolbarView::LoadImages() { 749 void ToolbarView::LoadImages() {
750 ui::ThemeProvider* tp = GetThemeProvider(); 750 ui::ThemeProvider* tp = GetThemeProvider();
751 751
752 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK)); 752 back_->SetImage(views::CustomButton::BS_NORMAL,
753 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H)); 753 tp->GetImageSkiaNamed(IDR_BACK));
754 back_->SetImage(views::CustomButton::BS_HOT,
755 tp->GetImageSkiaNamed(IDR_BACK_H));
754 back_->SetImage(views::CustomButton::BS_PUSHED, 756 back_->SetImage(views::CustomButton::BS_PUSHED,
755 tp->GetBitmapNamed(IDR_BACK_P)); 757 tp->GetImageSkiaNamed(IDR_BACK_P));
756 back_->SetImage(views::CustomButton::BS_DISABLED, 758 back_->SetImage(views::CustomButton::BS_DISABLED,
757 tp->GetBitmapNamed(IDR_BACK_D)); 759 tp->GetImageSkiaNamed(IDR_BACK_D));
758 760
759 forward_->SetImage(views::CustomButton::BS_NORMAL, 761 forward_->SetImage(views::CustomButton::BS_NORMAL,
760 tp->GetBitmapNamed(IDR_FORWARD)); 762 tp->GetImageSkiaNamed(IDR_FORWARD));
761 forward_->SetImage(views::CustomButton::BS_HOT, 763 forward_->SetImage(views::CustomButton::BS_HOT,
762 tp->GetBitmapNamed(IDR_FORWARD_H)); 764 tp->GetImageSkiaNamed(IDR_FORWARD_H));
763 forward_->SetImage(views::CustomButton::BS_PUSHED, 765 forward_->SetImage(views::CustomButton::BS_PUSHED,
764 tp->GetBitmapNamed(IDR_FORWARD_P)); 766 tp->GetImageSkiaNamed(IDR_FORWARD_P));
765 forward_->SetImage(views::CustomButton::BS_DISABLED, 767 forward_->SetImage(views::CustomButton::BS_DISABLED,
766 tp->GetBitmapNamed(IDR_FORWARD_D)); 768 tp->GetImageSkiaNamed(IDR_FORWARD_D));
767 769
768 reload_->SetImage(views::CustomButton::BS_NORMAL, 770 reload_->SetImage(views::CustomButton::BS_NORMAL,
769 tp->GetBitmapNamed(IDR_RELOAD)); 771 tp->GetImageSkiaNamed(IDR_RELOAD));
770 reload_->SetImage(views::CustomButton::BS_HOT, 772 reload_->SetImage(views::CustomButton::BS_HOT,
771 tp->GetBitmapNamed(IDR_RELOAD_H)); 773 tp->GetImageSkiaNamed(IDR_RELOAD_H));
772 reload_->SetImage(views::CustomButton::BS_PUSHED, 774 reload_->SetImage(views::CustomButton::BS_PUSHED,
773 tp->GetBitmapNamed(IDR_RELOAD_P)); 775 tp->GetImageSkiaNamed(IDR_RELOAD_P));
774 reload_->SetToggledImage(views::CustomButton::BS_NORMAL, 776 reload_->SetToggledImage(views::CustomButton::BS_NORMAL,
775 tp->GetBitmapNamed(IDR_STOP)); 777 tp->GetImageSkiaNamed(IDR_STOP));
776 reload_->SetToggledImage(views::CustomButton::BS_HOT, 778 reload_->SetToggledImage(views::CustomButton::BS_HOT,
777 tp->GetBitmapNamed(IDR_STOP_H)); 779 tp->GetImageSkiaNamed(IDR_STOP_H));
778 reload_->SetToggledImage(views::CustomButton::BS_PUSHED, 780 reload_->SetToggledImage(views::CustomButton::BS_PUSHED,
779 tp->GetBitmapNamed(IDR_STOP_P)); 781 tp->GetImageSkiaNamed(IDR_STOP_P));
780 reload_->SetToggledImage(views::CustomButton::BS_DISABLED, 782 reload_->SetToggledImage(views::CustomButton::BS_DISABLED,
781 tp->GetBitmapNamed(IDR_STOP_D)); 783 tp->GetImageSkiaNamed(IDR_STOP_D));
782 784
783 home_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_HOME)); 785 home_->SetImage(views::CustomButton::BS_NORMAL,
784 home_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_HOME_H)); 786 tp->GetImageSkiaNamed(IDR_HOME));
787 home_->SetImage(views::CustomButton::BS_HOT,
788 tp->GetImageSkiaNamed(IDR_HOME_H));
785 home_->SetImage(views::CustomButton::BS_PUSHED, 789 home_->SetImage(views::CustomButton::BS_PUSHED,
786 tp->GetBitmapNamed(IDR_HOME_P)); 790 tp->GetImageSkiaNamed(IDR_HOME_P));
787 791
788 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL)); 792 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL));
789 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT)); 793 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT));
790 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED)); 794 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED));
791 } 795 }
792 796
793 void ToolbarView::ShowCriticalNotification() { 797 void ToolbarView::ShowCriticalNotification() {
794 #if defined(OS_WIN) 798 #if defined(OS_WIN)
795 CriticalNotificationBubbleView* bubble_delegate = 799 CriticalNotificationBubbleView* bubble_delegate =
796 new CriticalNotificationBubbleView(app_menu_); 800 new CriticalNotificationBubbleView(app_menu_);
797 views::BubbleDelegateView::CreateBubble(bubble_delegate); 801 views::BubbleDelegateView::CreateBubble(bubble_delegate);
798 bubble_delegate->StartFade(true); 802 bubble_delegate->StartFade(true);
799 #endif 803 #endif
800 } 804 }
801 805
802 void ToolbarView::UpdateAppMenuState() { 806 void ToolbarView::UpdateAppMenuState() {
803 string16 accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP); 807 string16 accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP);
804 if (ShouldShowUpgradeRecommended()) { 808 if (ShouldShowUpgradeRecommended()) {
805 accname_app = l10n_util::GetStringFUTF16( 809 accname_app = l10n_util::GetStringFUTF16(
806 IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app); 810 IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app);
807 } 811 }
808 app_menu_->SetAccessibleName(accname_app); 812 app_menu_->SetAccessibleName(accname_app);
809 813
810 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL)); 814 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL));
811 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT)); 815 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT));
812 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED)); 816 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED));
813 SchedulePaint(); 817 SchedulePaint();
814 } 818 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/browser/ui/views/web_intent_picker_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698