Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 10382144: Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkia (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/find_bar_view.h" 5 #include "chrome/browser/ui/views/find_bar_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/string_number_conversions.h" 9 #include "base/string_number_conversions.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 AddChildView(match_count_text_); 93 AddChildView(match_count_text_);
94 94
95 // Create a focus forwarder view which sends focus to find_text_. 95 // Create a focus forwarder view which sends focus to find_text_.
96 focus_forwarder_view_ = new FocusForwarderView(find_text_); 96 focus_forwarder_view_ = new FocusForwarderView(find_text_);
97 AddChildView(focus_forwarder_view_); 97 AddChildView(focus_forwarder_view_);
98 98
99 find_previous_button_ = new views::ImageButton(this); 99 find_previous_button_ = new views::ImageButton(this);
100 find_previous_button_->set_tag(FIND_PREVIOUS_TAG); 100 find_previous_button_->set_tag(FIND_PREVIOUS_TAG);
101 find_previous_button_->set_focusable(true); 101 find_previous_button_->set_focusable(true);
102 find_previous_button_->SetImage(views::CustomButton::BS_NORMAL, 102 find_previous_button_->SetImage(views::CustomButton::BS_NORMAL,
103 rb.GetBitmapNamed(IDR_FINDINPAGE_PREV)); 103 rb.GetImageSkiaNamed(IDR_FINDINPAGE_PREV));
104 find_previous_button_->SetImage(views::CustomButton::BS_HOT, 104 find_previous_button_->SetImage(views::CustomButton::BS_HOT,
105 rb.GetBitmapNamed(IDR_FINDINPAGE_PREV_H)); 105 rb.GetImageSkiaNamed(IDR_FINDINPAGE_PREV_H));
106 find_previous_button_->SetImage(views::CustomButton::BS_DISABLED, 106 find_previous_button_->SetImage(views::CustomButton::BS_DISABLED,
107 rb.GetBitmapNamed(IDR_FINDINPAGE_PREV_P)); 107 rb.GetImageSkiaNamed(IDR_FINDINPAGE_PREV_P));
108 find_previous_button_->SetTooltipText( 108 find_previous_button_->SetTooltipText(
109 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP)); 109 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));
110 find_previous_button_->SetAccessibleName( 110 find_previous_button_->SetAccessibleName(
111 l10n_util::GetStringUTF16(IDS_ACCNAME_PREVIOUS)); 111 l10n_util::GetStringUTF16(IDS_ACCNAME_PREVIOUS));
112 AddChildView(find_previous_button_); 112 AddChildView(find_previous_button_);
113 113
114 find_next_button_ = new views::ImageButton(this); 114 find_next_button_ = new views::ImageButton(this);
115 find_next_button_->set_tag(FIND_NEXT_TAG); 115 find_next_button_->set_tag(FIND_NEXT_TAG);
116 find_next_button_->set_focusable(true); 116 find_next_button_->set_focusable(true);
117 find_next_button_->SetImage(views::CustomButton::BS_NORMAL, 117 find_next_button_->SetImage(views::CustomButton::BS_NORMAL,
118 rb.GetBitmapNamed(IDR_FINDINPAGE_NEXT)); 118 rb.GetImageSkiaNamed(IDR_FINDINPAGE_NEXT));
119 find_next_button_->SetImage(views::CustomButton::BS_HOT, 119 find_next_button_->SetImage(views::CustomButton::BS_HOT,
120 rb.GetBitmapNamed(IDR_FINDINPAGE_NEXT_H)); 120 rb.GetImageSkiaNamed(IDR_FINDINPAGE_NEXT_H));
121 find_next_button_->SetImage(views::CustomButton::BS_DISABLED, 121 find_next_button_->SetImage(views::CustomButton::BS_DISABLED,
122 rb.GetBitmapNamed(IDR_FINDINPAGE_NEXT_P)); 122 rb.GetImageSkiaNamed(IDR_FINDINPAGE_NEXT_P));
123 find_next_button_->SetTooltipText( 123 find_next_button_->SetTooltipText(
124 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP)); 124 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));
125 find_next_button_->SetAccessibleName( 125 find_next_button_->SetAccessibleName(
126 l10n_util::GetStringUTF16(IDS_ACCNAME_NEXT)); 126 l10n_util::GetStringUTF16(IDS_ACCNAME_NEXT));
127 AddChildView(find_next_button_); 127 AddChildView(find_next_button_);
128 128
129 close_button_ = new views::ImageButton(this); 129 close_button_ = new views::ImageButton(this);
130 close_button_->set_tag(CLOSE_TAG); 130 close_button_->set_tag(CLOSE_TAG);
131 close_button_->set_focusable(true); 131 close_button_->set_focusable(true);
132 close_button_->SetImage(views::CustomButton::BS_NORMAL, 132 close_button_->SetImage(views::CustomButton::BS_NORMAL,
133 rb.GetBitmapNamed(IDR_CLOSE_BAR)); 133 rb.GetImageSkiaNamed(IDR_CLOSE_BAR));
134 close_button_->SetImage(views::CustomButton::BS_HOT, 134 close_button_->SetImage(views::CustomButton::BS_HOT,
135 rb.GetBitmapNamed(IDR_CLOSE_BAR_H)); 135 rb.GetImageSkiaNamed(IDR_CLOSE_BAR_H));
136 close_button_->SetImage(views::CustomButton::BS_PUSHED, 136 close_button_->SetImage(views::CustomButton::BS_PUSHED,
137 rb.GetBitmapNamed(IDR_CLOSE_BAR_P)); 137 rb.GetImageSkiaNamed(IDR_CLOSE_BAR_P));
138 close_button_->SetTooltipText( 138 close_button_->SetTooltipText(
139 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP)); 139 l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));
140 close_button_->SetAccessibleName( 140 close_button_->SetAccessibleName(
141 l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE)); 141 l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE));
142 AddChildView(close_button_); 142 AddChildView(close_button_);
143 143
144 SetBackground(rb.GetBitmapNamed(IDR_FIND_DLG_LEFT_BACKGROUND), 144 SetBackground(rb.GetImageSkiaNamed(IDR_FIND_DLG_LEFT_BACKGROUND),
145 rb.GetBitmapNamed(IDR_FIND_DLG_RIGHT_BACKGROUND)); 145 rb.GetImageSkiaNamed(IDR_FIND_DLG_RIGHT_BACKGROUND));
146 146
147 SetBorder(IDR_FIND_DIALOG_LEFT, IDR_FIND_DIALOG_MIDDLE, 147 SetBorder(IDR_FIND_DIALOG_LEFT, IDR_FIND_DIALOG_MIDDLE,
148 IDR_FIND_DIALOG_RIGHT); 148 IDR_FIND_DIALOG_RIGHT);
149 149
150 preferred_height_ = rb.GetBitmapNamed(IDR_FIND_DIALOG_MIDDLE)->height(); 150 preferred_height_ = rb.GetBitmapNamed(IDR_FIND_DIALOG_MIDDLE)->height();
151 151
152 // Background images for the Find edit box. 152 // Background images for the Find edit box.
153 text_box_background_ = rb.GetBitmapNamed(IDR_FIND_BOX_BACKGROUND); 153 text_box_background_ = rb.GetBitmapNamed(IDR_FIND_BOX_BACKGROUND);
154 text_box_background_left_ = rb.GetBitmapNamed(IDR_FIND_BOX_BACKGROUND_LEFT); 154 text_box_background_left_ = rb.GetBitmapNamed(IDR_FIND_BOX_BACKGROUND_LEFT);
155 155
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 482
483 FindBarHost* FindBarView::find_bar_host() const { 483 FindBarHost* FindBarView::find_bar_host() const {
484 return static_cast<FindBarHost*>(host()); 484 return static_cast<FindBarHost*>(host());
485 } 485 }
486 486
487 void FindBarView::OnThemeChanged() { 487 void FindBarView::OnThemeChanged() {
488 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 488 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
489 if (GetThemeProvider()) { 489 if (GetThemeProvider()) {
490 close_button_->SetBackground( 490 close_button_->SetBackground(
491 GetThemeProvider()->GetColor(ThemeService::COLOR_TAB_TEXT), 491 GetThemeProvider()->GetColor(ThemeService::COLOR_TAB_TEXT),
492 rb.GetBitmapNamed(IDR_CLOSE_BAR), 492 rb.GetImageSkiaNamed(IDR_CLOSE_BAR),
493 rb.GetBitmapNamed(IDR_CLOSE_BAR_MASK)); 493 rb.GetImageSkiaNamed(IDR_CLOSE_BAR_MASK));
494 } 494 }
495 } 495 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698