Issue 10382138: PPAPI/NaCl: Fix IPC ppapi proxy build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382138: PPAPI/NaCl: Fix IPC ppapi proxy build (Closed)

Created:
8 years, 7 months ago by dmichael (off chromium)

Modified:
8 years, 7 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI/NaCl: Fix IPC ppapi proxy build Take files out of ppapi_proxy_untrusted.gyp that have been removed. Roll googleurl DEPS. BUG=116317 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137158

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	ppapi/ppapi_proxy_untrusted.gyp	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bbudge

I think you might also have to remove: 'proxy/ppb_text_input_proxy.cc',

8 years, 7 months ago (2012-05-11 21:19:14 UTC) #2

dmichael (off chromium)

Threw in the google-url DEPS roll as a bonus.

8 years, 7 months ago (2012-05-11 21:45:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10382138/10001

8 years, 7 months ago (2012-05-14 22:25:48 UTC) #6

commit-bot: I haz the power

8 years, 7 months ago (2012-05-15 00:32:10 UTC) #7

Try job failure for 10382138-10001 (retry) on win_rel for steps "browser_tests,
unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages