chrome/browser/safe_browsing/download_protection_service.h - Issue 10382113: Add SafeBrowsing support for checking downloaded zip files that contain executables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.h

Issue 10382113: Add SafeBrowsing support for checking downloaded zip files that contain executables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix FilePath printf format on Windows Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/safe_browsing/download_protection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service.h

diff --git a/chrome/browser/safe_browsing/download_protection_service.h b/chrome/browser/safe_browsing/download_protection_service.h

index 4a5102147e457f8fd1934e3912051c2ccc32a6ee..7509e19a072c40299ef93b37b1c1807535f29e1d 100644

--- a/chrome/browser/safe_browsing/download_protection_service.h

+++ b/chrome/browser/safe_browsing/download_protection_service.h

@@ -49,6 +49,7 @@ class DownloadProtectionService {

int64 total_bytes;

bool user_initiated;

std::string remote_address;

+ bool zipped_executable;

DownloadInfo();

~DownloadInfo();

std::string DebugString() const;

@@ -137,6 +138,7 @@ class DownloadProtectionService {

REASON_DOWNLOAD_UNCOMMON,

REASON_DOWNLOAD_NOT_SUPPORTED,

REASON_INVALID_RESPONSE_VERDICT,

+ REASON_ARCHIVE_WITHOUT_BINARIES,

REASON_MAX // Always add new values before this one.

};

@@ -148,6 +150,8 @@ class DownloadProtectionService {

FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,

CheckClientDownloadSuccess);

FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,

+ CheckClientDownloadZip);

+ FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,

CheckClientDownloadFetchFailed);

FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,

TestDownloadRequestTimeout);