Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: media/base/download_rate_monitor_unittest.cc

Issue 10382109: Delete DownloadRateMonitor since it's never worked right. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/download_rate_monitor.cc ('k') | media/base/pipeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/download_rate_monitor_unittest.cc
diff --git a/media/base/download_rate_monitor_unittest.cc b/media/base/download_rate_monitor_unittest.cc
deleted file mode 100644
index 321ad630e51c0011a8551386120f22f1846bb851..0000000000000000000000000000000000000000
--- a/media/base/download_rate_monitor_unittest.cc
+++ /dev/null
@@ -1,165 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "media/base/download_rate_monitor.h"
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using ::testing::Mock;
-
-namespace media {
-
-class DownloadRateMonitorTest : public ::testing::Test {
- public:
- DownloadRateMonitorTest() {
- monitor_.set_total_bytes(kMediaSizeInBytes);
- }
-
- virtual ~DownloadRateMonitorTest() { }
-
- MOCK_METHOD0(CanPlayThrough, void());
-
- protected:
- static const int kMediaSizeInBytes = 20 * 1024 * 1024;
-
- // Simulates downloading of the media file. Packets are timed evenly in
- // |ms_between_packets| intervals, starting at |starting_time|, which is
- // number of seconds since unix epoch (Jan 1, 1970).
- // Returns the number of bytes buffered in the media file after the
- // network activity.
- int SimulateNetwork(double starting_time,
- int starting_bytes,
- int bytes_per_packet,
- int ms_between_packets,
- int number_of_packets) {
- int bytes_buffered = starting_bytes;
- base::Time packet_time = base::Time::FromDoubleT(starting_time);
-
- monitor_.SetNetworkActivity(true);
- // Loop executes (number_of_packets + 1) times because a packet needs a
- // starting and end point.
- for (int i = 0; i < number_of_packets + 1; ++i) {
- monitor_.SetBufferedBytes(bytes_buffered, packet_time);
- packet_time += base::TimeDelta::FromMilliseconds(ms_between_packets);
- bytes_buffered += bytes_per_packet;
- }
- monitor_.SetNetworkActivity(false);
- return bytes_buffered;
- }
-
- void StartMonitor(int bitrate) {
- StartMonitor(bitrate, false, false);
- }
-
- void StartMonitor(int bitrate, bool streaming, bool local_source) {
- monitor_.Start(base::Bind(&DownloadRateMonitorTest::CanPlayThrough,
- base::Unretained(this)), bitrate, streaming, local_source);
- }
-
- DownloadRateMonitor monitor_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(DownloadRateMonitorTest);
-};
-
-TEST_F(DownloadRateMonitorTest, DownloadRateGreaterThanBitrate) {
- static const int media_bitrate = 1024 * 1024 * 8;
-
- // Simulate downloading at double the media's bitrate.
- StartMonitor(media_bitrate);
- EXPECT_CALL(*this, CanPlayThrough());
- SimulateNetwork(1, 0, 2 * media_bitrate / 8, 1000, 10);
-}
-
-// If the user pauses and the pipeline stops downloading data, make sure the
-// DownloadRateMonitor understands that the download is not stalling.
-TEST_F(DownloadRateMonitorTest, DownloadRateGreaterThanBitrate_Pause) {
- static const int media_bitrate = 1024 * 1024 * 8;
- static const int download_byte_rate = 1.1 * media_bitrate / 8;
-
- // Start downloading faster than the media's bitrate.
- StartMonitor(media_bitrate);
- EXPECT_CALL(*this, CanPlayThrough());
- int buffered = SimulateNetwork(1, 0, download_byte_rate, 1000, 2);
-
- // Then "pause" for 3 minutes and continue downloading at same rate.
- SimulateNetwork(60 * 3, buffered, download_byte_rate, 1000, 4);
-}
-
-TEST_F(DownloadRateMonitorTest, DownloadRateGreaterThanBitrate_SeekForward) {
- static const int media_bitrate = 1024 * 1024 * 8;
- static const int download_byte_rate = 1.1 * media_bitrate / 8;
-
- // Start downloading faster than the media's bitrate.
- EXPECT_CALL(*this, CanPlayThrough());
- StartMonitor(media_bitrate);
- SimulateNetwork(1, 0, download_byte_rate, 1000, 2);
-
- // Then seek forward mid-file and continue downloading at same rate.
- SimulateNetwork(4, kMediaSizeInBytes / 2, download_byte_rate, 1000, 4);
-}
-
-TEST_F(DownloadRateMonitorTest, DownloadRateGreaterThanBitrate_SeekBackward) {
- static const int media_bitrate = 1024 * 1024 * 8;
- static const int download_byte_rate = 1.1 * media_bitrate / 8;
-
- // Start downloading faster than the media's bitrate, in middle of file.
- StartMonitor(media_bitrate);
- SimulateNetwork(1, kMediaSizeInBytes / 2, download_byte_rate, 1000, 2);
-
- // Then seek back to beginning and continue downloading at same rate.
- EXPECT_CALL(*this, CanPlayThrough());
- SimulateNetwork(4, 0, download_byte_rate, 1000, 4);
-}
-
-TEST_F(DownloadRateMonitorTest, DownloadRateLessThanBitrate) {
- static const int media_bitrate = 1024 * 1024 * 8;
-
- // Simulate downloading at half the media's bitrate.
- EXPECT_CALL(*this, CanPlayThrough())
- .Times(0);
- StartMonitor(media_bitrate);
- SimulateNetwork(1, 0, media_bitrate / 8 / 2, 1000, 10);
-}
-
-TEST_F(DownloadRateMonitorTest, MediaSourceIsLocal) {
- static const int media_bitrate = 1024 * 1024 * 8;
-
- // Simulate no data downloaded.
- EXPECT_CALL(*this, CanPlayThrough());
- StartMonitor(media_bitrate, false, true);
-}
-
-TEST_F(DownloadRateMonitorTest, MediaSourceIsStreaming) {
- static const int media_bitrate = 1024 * 1024 * 8;
-
- // Simulate downloading at the media's bitrate while streaming.
- EXPECT_CALL(*this, CanPlayThrough());
- StartMonitor(media_bitrate, true, false);
- SimulateNetwork(1, 0, media_bitrate / 8, 1000, 10);
-}
-
-TEST_F(DownloadRateMonitorTest, VeryFastDownloadRate) {
- static const int media_bitrate = 1024 * 1024 * 8;
-
- // Simulate downloading half the video very quickly in one chunk.
- StartMonitor(media_bitrate);
- EXPECT_CALL(*this, CanPlayThrough());
- SimulateNetwork(1, 0, kMediaSizeInBytes / 2, 10, 1);
-}
-
-TEST_F(DownloadRateMonitorTest, DownloadEntireVideo) {
- static const int seconds_of_data = 20;
- static const int media_bitrate = kMediaSizeInBytes * 8 / seconds_of_data;
-
- // Simulate downloading entire video at half the bitrate of the video.
- StartMonitor(media_bitrate);
- EXPECT_CALL(*this, CanPlayThrough());
- SimulateNetwork(1, 0, media_bitrate / 8 / 2, 1000, seconds_of_data * 2);
-}
-
-} // namespace media
« no previous file with comments | « media/base/download_rate_monitor.cc ('k') | media/base/pipeline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698