Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: net/spdy/spdy_stream.cc

Issue 10382107: Change the stream_id for streams which are serialized out of order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add spdy2 version of the test. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_session.cc ('K') | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream.cc
diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc
index c3b06868bafbe302f189fc0596c1d5f5fe150b9c..3f95662566ad746ea0375447746759ef1a25e9da 100644
--- a/net/spdy/spdy_stream.cc
+++ b/net/spdy/spdy_stream.cc
@@ -519,6 +519,9 @@ int SpdyStream::SendRequest(bool has_upload_data) {
int SpdyStream::WriteStreamData(IOBuffer* data, int length,
SpdyDataFlags flags) {
+ // Until the headers have been completely sent, we can not be sure
+ // that our stream_id is correct.
+ DCHECK(io_state_ > STATE_SEND_HEADERS_COMPLETE);
willchan no longer on Chromium 2012/05/15 14:04:30 Btw, does DCHECK_GT work here?
Ryan Hamilton 2012/05/15 16:41:11 Done.
return session_->WriteStreamData(stream_id_, data, length, flags);
}
« net/spdy/spdy_session.cc ('K') | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698