Issue 10382089: Http cache: Don't attempt to doom the same entry multiple times

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382089: Http cache: Don't attempt to doom the same entry multiple times (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)

Modified:
8 years, 7 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Http cache: Don't attempt to doom the same entry multiple times and make sure that side effects of adding the truncation flag are considered by the cache. BUG=125159 TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136172

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -3 lines)			Patch
M	net/http/http_cache.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/http/http_cache_transaction.h	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	net/http/http_cache_transaction.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View	1 chunk	+97 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gavinp

lgtm http://codereview.chromium.org/10382089/diff/1/net/http/http_cache_transaction.h File net/http/http_cache_transaction.h (right): http://codereview.chromium.org/10382089/diff/1/net/http/http_cache_transaction.h#newcode88 net/http/http_cache_transaction.h:88: // success. Keep in mind that this operation ...

8 years, 7 months ago (2012-05-09 22:10:12 UTC) #2

Thanks.

Expand Messages | Collapse Messages